Connecting OBSOLETE_ATTRIBUTES with OBSOLETE_ATTRIBUTES_MSG #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a refactor in Assertions.java which joins together OBSOLTE_ATTRIBUTES & OBSOLETE_ATTRIBUTES_MSG.
It will allow to add different messages for the same attribute name, depending element name in which it was used.
For example attribute
charsetfor elementsaandlinkshould have suggestionUse an HTTP Content-Type header on the linked resource instead., but for elementscriptsuggestion should be empty.It also removes
&& "ol" != localName && "ul" != localName && "li" != localNamewhich seems to be unneccessary.