Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build status badges #643

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

schliflo
Copy link
Contributor

No description provided.

@sideshowbarker
Copy link
Contributor

Thanks but I should note that the lack of the Travis badge is intentional — I added it at one time but then subsequently removed it, because it’s not clear to me what the value of it is to users. I mean, if the build isn’t passing, I’m already going to know myself and will already be working on getting it fixed. I’m not sure what benefit there is to users in the mean time in seeing the indicator that it’s broken. Nor for that matter do I know the benefit of the “build passing” badge is to users…

@schliflo
Copy link
Contributor Author

schliflo commented May 7, 2018

I figured it's a good way for users to see wether the current build is OK to use or not. If you don't see a benefit or simply don't wat the badge feel free to close the PR. I didn't know that you intentionally left it out.

@XhmikosR XhmikosR changed the title Add Travis CI build status badge Add CI build status badges Oct 6, 2018
# The Nu Html Checker (v.Nu) [![Chat room][1]][2] [![Download latest][3]][4]
# The Nu Html Checker (v.Nu)

[![Linux Build Status](https://img.shields.io/travis/validator/validator/master.svg?label=Linux%20build)](https://travis-ci.org/validator/validator) [![Windows Build status](https://img.shields.io/appveyor/ci/sideshowbarker/validator/master.svg?label=Windows%20build)](https://ci.appveyor.com/project/sideshowbarker/validator) [![Chat room][1]][2] [![Download latest][3]][4]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR maybe add docker badge as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final decision is @sideshowbarker's. I definitely want to have the CI badges so that I can find the CI projects easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'ts a similar thing with the docker hub image, which is linked further down in the readme, but there's no quick way to find it atm. I'd be happy to add it if @sideshowbarker is fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants