Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isIBAN): narrow regex for VG #2339

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Nov 18, 2023

The Virgin Islands Bank Codes can only be non numeric characters.

Sources

See also

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (83d6ffd) to head (5f0757e).
Report is 2 commits behind head on master.

Current head 5f0757e differs from pull request most recent head fe0202b

Please upload reports for the commit fe0202b to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2339      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          108      107       -1     
  Lines         2482     2449      -33     
  Branches       627      619       -8     
===========================================
- Hits          2482     2448      -34     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubiin
rubiin previously approved these changes May 12, 2024
WikiRik
WikiRik previously approved these changes May 17, 2024
@rubiin rubiin requested a review from profnandaa May 18, 2024 08:24
@ST-DDT ST-DDT dismissed stale reviews from WikiRik and rubiin via fe0202b June 1, 2024 15:18
@rubiin rubiin requested a review from WikiRik June 1, 2024 16:55
@profnandaa profnandaa merged commit 28ff5d3 into validatorjs:master Jun 1, 2024
10 checks passed
@ST-DDT ST-DDT deleted the fix/iban/vg branch June 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants