Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py to include all modules for PyGQLC #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ricardoleal20
Copy link
Member

@ricardoleal20 ricardoleal20 commented Feb 14, 2023

Description

The actual PyGQLC at the moment of build the dependencies to upload them to PyPi doesn't include all. This PR fix the line that decides what's going inside of that build.

Fixes #TEPYG-77

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Build on local.
Before After
image image
Before, the helper_modules were not included Now, it's included and you can see the modules inside it.
Nothing to show since the helper modules were not included image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@EBKH EBKH added the ValueChainOS PRs related to ValueChainOS development label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ValueChainOS PRs related to ValueChainOS development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants