New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactore: Move test to seprate module to can be run separetly #441
base: unstable
Are you sure you want to change the base?
Conversation
Signed-off-by: aliraad79 <a.ahmadi.k.79@gmail.com>
Signed-off-by: aliraad79 <a.ahmadi.k.79@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #441 +/- ##
============================================
+ Coverage 68.40% 68.45% +0.04%
============================================
Files 109 109
Lines 61673 61673
============================================
+ Hits 42189 42219 +30
+ Misses 19484 19454 -30
|
Thanks for helping, it looks like some of the tests are failing. Did you run:
To make sure they all run? |
No i don't do that. I fix the tests and push it again. |
Signed-off-by: aliraad79 <a.ahmadi.k.79@gmail.com>
Hi. I fix some problems but there is some bigger problems. |
For other tests like listpack we've just been including the .c file. Since some other folks have already ported some of the other tests, do you mind just re-submitting the PR just for the dict.c test case? It's a bit easier to merge as well. |
Hi, I think this will help with #428 merge request.
This is my first merge request on this repo and any comment is helpful for me.
Thank you in advance.
Fix #428