Use kqueue as the backend of AE on DragonFlyBSD #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #450 +/- ##
============================================
+ Coverage 69.85% 69.87% +0.02%
============================================
Files 109 109
Lines 61791 61791
============================================
+ Hits 43164 43179 +15
+ Misses 18627 18612 -15 |
panjf2000
force-pushed
the
kqueue-dragonfly
branch
from
31645b7
to
1c9ccab
Compare
madolson
reviewed
May 8, 2024
panjf2000
force-pushed
the
kqueue-dragonfly
branch
from
1c9ccab
to
8233878
Compare
|
@madolson Any updates? |
Currently, we use select(2) on DragonFlyBSD while kqueue is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 select(2) is a pretty old technique that has many defects compared to kqueue, we should switch to kqueue on DragonFlyBSD. --------- Signed-off-by: Andy Pan <i@andypan.me>
panjf2000
force-pushed
the
kqueue-dragonfly
branch
from
8233878
to
24060c9
Compare
madolson
approved these changes
May 12, 2024
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 15, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me>
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 15, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 15, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
hallmason17
pushed a commit
to hallmason17/valkey
that referenced
this pull request
May 15, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me>
hallmason17
pushed a commit
to hallmason17/valkey
that referenced
this pull request
May 18, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me>
srgsanky
pushed a commit
to srgsanky/valkey
that referenced
this pull request
May 19, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me>
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 22, 2024
Currently, we use select(2) on DragonFlyBSD while `kqueue` is available on DragonFlyBSD since FreeBSD 4.1 and DragonFlyBSD was originally forked from FreeBSD 4.8 `select(2)` is a pretty old technique that has many defects compared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD. Signed-off-by: Andy Pan <i@andypan.me> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use select(2) on DragonFlyBSD while
kqueueis available on DragonFlyBSD since FreeBSD 4.1and DragonFlyBSD was originally forked from FreeBSD 4.8
select(2)is a pretty old technique that has many defectscompared to
kqueue, we should switch tokqueueon DragonFlyBSD.