New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate endianconv.c unit tests to new test framework #458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #458 +/- ##
============================================
+ Coverage 68.91% 69.83% +0.92%
============================================
Files 109 109
Lines 61793 61801 +8
============================================
+ Hits 42582 43159 +577
+ Misses 19211 18642 -569
|
I didn’t remove the legacy endianconvTest from serverTest (see commit 1c59ca7 ) since it gives conflict which I couldn’t resolve anyway. I thought of doing it in a subsequent PR. I am not sure whethere there is any other alternative. |
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This reverts commit 6fcd60f. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
d1c2cbf
to
3fae284
Compare
@madolson could you please review and merge the above, thanks. |
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
This PR migrates all tests related to endianconv into new test framework as part of the parent issue #428.