-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(points): add track points event to transaction watcher #5441
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5441 +/- ##
=======================================
Coverage 86.34% 86.35%
=======================================
Files 756 756
Lines 31266 31271 +5
Branches 5376 5378 +2
=======================================
+ Hits 26998 27004 +6
+ Misses 4035 4034 -1
Partials 233 233
Continue to review full report in Codecov by Sentry.
|
src/points/types.ts
Outdated
@@ -84,6 +85,7 @@ interface PointsEventCreateWallet { | |||
interface PointsEventSwap { | |||
activityId: 'swap' | |||
transactionHash: string | |||
network: Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of using NetworkId
to remove any ambiguity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes fair, i updated to use networkId. i thought i was saving some computation by using the network but i was mistaken (reading the wallet code i thought that we need only the network to create the viem client, but we've a couple of layers of mappings in between!)
Description
In case the transaction is not settled within the same app session, we should add the points tracking to the transaction watcher as well.
I added the network to the tracked event, in preparation for network specific activities.
Test plan
n/a
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: