Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected panic when calling Do of a PipelineClient #997

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix unexpected panic when calling Do of a PipelineClient #997

merged 2 commits into from
Mar 17, 2021

Commits on Mar 17, 2021

  1. fix: Unexpected panic for PipelineClient 

    PipelineClient would panic when calling `Do` with a nil Response as
the second parm

This commit fixes the unexpected panic by checking nil first before
setting fields for Response
    @blanet
    blanet committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    bec35f7 View commit details
    Browse the repository at this point in the history

  2. Add tests to ensure nil resp is valid for PipelineClient

    @blanet
    blanet committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    5488728 View commit details
    Browse the repository at this point in the history