Skip to content

Commit

Permalink
chore: Add 7012 and 6003 backward compatibility check errors to ignor…
Browse files Browse the repository at this point in the history
…elist

This is totally expected, since it is an alpha client and both of those errors (`6003` - public constant value change, and `7012` - addition of a method to an interface) are expected given the underlying change. Specifially the `optional` keyword was added to `compute.proto`, which caused addition of `has<FieldName>()` methods to proto stubs and respective builders (error 7012). The field numbers change (error `6003`) was caused by the rollback of the previous hack (googleapis/googleapis-discovery#31) which, in its turn, was caused by a bug in protobuf.
  • Loading branch information
vam-google committed May 10, 2021
1 parent 221e6b0 commit e19c666
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 0 deletions.
8 changes: 8 additions & 0 deletions clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,12 @@
<differenceType>8001</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>6003</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
</differences>
8 changes: 8 additions & 0 deletions google-cloud-compute-bom/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,12 @@
<differenceType>8001</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>6003</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
</differences>
8 changes: 8 additions & 0 deletions google-cloud-compute/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,12 @@
<differenceType>8001</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>6003</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
</differences>
8 changes: 8 additions & 0 deletions proto-google-cloud-compute-v1/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,12 @@
<differenceType>8001</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>6003</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/compute/**</className>
</difference>
</differences>

0 comments on commit e19c666

Please sign in to comment.