New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new compiler in Vite plugin #1264
Merged
Merged
+596
−718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `vite-next` fixture runner
…dy transformed files
🦋 Changeset detectedLatest commit: 030d8df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrm007
commented
Jan 10, 2024
tests/e2e/thirdparty.playwright.ts-snapshots/thirdparty-vite-next--production.css
Outdated
Show resolved
Hide resolved
askoufis
reviewed
Jan 23, 2024
mattcompiles
approved these changes
Jan 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1211.
This PR rewrites the Vite plugin to use a new compiler powered by vite-node, introduced by @markdalgleish in #1030.
TL;DR: the new plugin is ~5x faster (on average) than the current plugin. More details can be found in each changeset.
Pre-release versions (snapshots) of this plugin can be found here: Github Actions (install them with
pnpm add @vanilla-extract/vite-plugin@vite-plugin-new
).I've tested various snapshots in Remix using the unstable Vite plugin.
Using a fresh app created with sku init, with Braid and Remix, the results are below:
I also tested in a repo that had performance issues with Mantine: