Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm 0.18 compatibility #4

Merged
merged 5 commits into from Aug 20, 2018
Merged

Elm 0.18 compatibility #4

merged 5 commits into from Aug 20, 2018

Conversation

spookylukey
Copy link
Collaborator

Fixes for Elm 0.18, plus updates for latest elm-test.

@vanwagonet
Copy link
Owner

I merged the elm-format commit. Could you rebase, and take a look at the .travis.yml?

I haven't done anything in elm for a long while, and am not sure what the best way to do CI is.

@spookylukey
Copy link
Collaborator Author

@vanwagonet I'll have a look, one of them is the code linter complaining it seems, I'm not sure about the other.

@spookylukey
Copy link
Collaborator Author

@vanwagonet OK, progress here.

We are now seeing failures only on 'stable' Node (v10.9.0), which is what I also get locally, while lts (v8.11.4) passes.

My guesses are regressions in Intl support in Node, or possibly these are real bugs in elm-intl that have been uncovered by better Intl support in Node, I don't have time to look into these at the moment.

@vanwagonet
Copy link
Owner

I think there are actual regressions in Node v10 Intl support. nodejs/node#22156

I think this is good to merge.

@vanwagonet vanwagonet merged commit 8dfc0cf into vanwagonet:master Aug 20, 2018
@srl295
Copy link

srl295 commented Oct 19, 2018

@vanwagonet ^ regression fixed in nodejs/node#23764

@vanwagonet
Copy link
Owner

Thanks @srl295!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants