Add more info about favicon.ico. #897
Conversation
| @@ -35,6 +35,35 @@ let fileMiddleware = FileMiddleware( | |||
| app.middleware.use(fileMiddleware) | |||
| ``` | |||
|
|
|||
| If running from Xcode please set the project schema run option working directory. | |||
| See [here](https://docs.vapor.codes/getting-started/xcode/#custom-working-directory) for more information. | |||
There was a problem hiding this comment.
You need to use an 'local' link to another markdown file, not an absolute link. The current link doesn't work with localization
|
Will do.
W dniu pon., 4.09.2023 o 16:58 Joannis Orlandos ***@***.***>
napisał(a):
… ***@***.**** requested changes on this pull request.
------------------------------
In docs/getting-started/folder-structure.md
<#897 (comment)>:
> @@ -35,6 +35,35 @@ let fileMiddleware = FileMiddleware(
app.middleware.use(fileMiddleware)
```
+If running from Xcode please set the project schema run option working directory.
+See [here](https://docs.vapor.codes/getting-started/xcode/#custom-working-directory) for more information.
You need to use an 'local' link to another markdown file, not an absolute
link. The current link doesn't work with localization
—
Reply to this email directly, view it on GitHub
<#897 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMRLK4VLLS6NT4LQYMWXPLXYXT77ANCNFSM6AAAAAA4KRPLJU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Need translations. |
|
|
||
| To see the `favicon.ico` in action prepare a route in `/Sources/App/routes.swift` like this: | ||
|
|
||
| ```swift |
There was a problem hiding this comment.
While I agree that the current docs are pretty unhelpful. I think it might be better to change the existing favicon.ico example to be a different type of file.
There was a problem hiding this comment.
The favicon.ico icon is always added at some point in a process of building a full-feature website. It think it should stay.
There was a problem hiding this comment.
We already have a section on the FileMiddleware so we should just link to that.
I agree however that we should add the note about setting the custom working directory alongside though
|
I moved the favicon sample to |
So basically I am going through the docs and found a problem for novice users.
I am linking the article about Xcode working directory paths for use case when running from Xcode. (here)
I am adding the sample for testing a favicon ready website.
Thanks.