Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Removals for v2 #445

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Draft: Removals for v2 #445

wants to merge 19 commits into from

Conversation

fabianfett
Copy link
Collaborator

This is a quick and dirty draft of the removals that we want to do for v2. Happy to split this into smaller prs (see commits).

@fabianfett fabianfett added semver-major Breaks existing public API. breaking To fix this bug or implement this feature we must break API labels Dec 13, 2023
@fabianfett fabianfett added this to the 2.0.0 milestone Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (69ccfdf) 62.28% compared to head (ce3fee6) 72.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #445       +/-   ##
===========================================
+ Coverage   62.28%   72.71%   +10.43%     
===========================================
  Files         124       74       -50     
  Lines        9937     8319     -1618     
===========================================
- Hits         6189     6049      -140     
+ Misses       3748     2270     -1478     
Files Coverage Δ
.../Connection/PostgresConnection+Configuration.swift 50.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresDataType.swift 55.94% <ø> (-0.26%) ⬇️
Sources/PostgresNIO/Data/PostgresNumeric.swift 78.60% <ø> (ø)
Sources/PostgresNIO/Data/PostgresRow.swift 70.27% <ø> (+21.82%) ⬆️
...tion State Machine/ExtendedQueryStateMachine.swift 79.59% <100.00%> (ø)
... State Machine/PreparedStatementStateMachine.swift 91.83% <100.00%> (ø)
Sources/PostgresNIO/New/PSQLEventsHandler.swift 72.41% <ø> (ø)
Sources/PostgresNIO/New/PSQLTask.swift 78.12% <100.00%> (ø)
Sources/PostgresNIO/New/PostgresQuery.swift 82.44% <ø> (+1.14%) ⬆️
Sources/PostgresNIO/Utilities/NIOUtils.swift 0.00% <ø> (ø)
... and 11 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking To fix this bug or implement this feature we must break API semver-major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants