Cleanup: Logging and some more #447
Conversation
| @@ -563,8 +563,8 @@ final class PostgresChannelHandler: ChannelDuplexHandler { | |||
| _ cleanup: ConnectionStateMachine.ConnectionAction.CleanUpContext, | |||
| context: ChannelHandlerContext | |||
| ) { | |||
| self.logger.debug("Cleaning up and closing connection.", metadata: [.error: "\(cleanup.error)"]) | |||
|
|
|||
| self.logger.debug("Cleaning up and closing connection.", metadata: [.error: "\(String(reflecting: cleanup.error))"]) | |||
There was a problem hiding this comment.
Example of what it solves:
| @@ -280,7 +280,7 @@ final class PSQLRowStream: @unchecked Sendable { | |||
| precondition(!newRows.isEmpty, "Expected to get rows!") | |||
| self.eventLoop.preconditionInEventLoop() | |||
| self.logger.trace("Row stream received rows", metadata: [ | |||
| "row_count": "\(newRows.count)" | |||
| .rowCount: "\(newRows.count)" | |||
There was a problem hiding this comment.
inconsistency with all other log statements.
| @@ -803,7 +803,7 @@ final class ConnectionPoolTests: XCTestCase { | |||
|
|
|||
| pool.connectionReceivedNewMaxStreamSetting(connection, newMaxStreamSetting: 21) | |||
|
|
|||
| for (index, request) in requests.enumerated() { | |||
| for (_, request) in requests.enumerated() { | |||
There was a problem hiding this comment.
warning for unused variable.
| @@ -22,7 +22,6 @@ extension PostgresJSONDecoder { | |||
| } | |||
| } | |||
|
|
|||
| //@available(macOS 13.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *) | |||
There was a problem hiding this comment.
There are some Sendable warning for these 2 JSON-Coder conformances. I didn't try to solve them because someone (Fabian probably?) tried to solve them but apparently stopped at some point (judging by the comment).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 62.18% 62.20% +0.02%
==========================================
Files 124 124
Lines 9936 9936
==========================================
+ Hits 6179 6181 +2
+ Misses 3757 3755 -2
|
MahdiBM
requested review from
gwynne and
fabianfett
and removed request for
gwynne
|
Related #411. |
|
Logging as well as Errors currently suck in PostgresNIO. I'm allowed to say that, as I was the one who implemented those. We should come up with a better logging and error plan first. Sadly I'm currently extremely low on time. @MahdiBM would you be interested in moving this forward? |
|
@fabianfett sure, but I don't have a plan of myself. How should we proceed? |
|
<code-ql action is broken everywhere for now> |
No description provided.