This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Support getting generic and type-safe process environment variables via LosslessStringConvertible protocol
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia `LosslessStringConvertible` protocol
|
LGTM! 👍 |
tanner0101
suggested changes
Mar 5, 2019
There was a problem hiding this comment.
This addition LGTM, thanks! We just need to make a slight change to circle CI. Would you mind doing that?
In https://github.com/vapor/service/blob/1/circle.yml
linux-fluent-postgresqlneeds to checkout branch1instead ofmasterlinux-vaporneeds to checkout branch3instead ofmaster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.