Fix overhaul breakage, part 2 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
approved these changes
Apr 16, 2024
|
Thanks @gwynne!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 3.29.2
This solves the source code breakage issue first reported in #175 - shout out and thanks to @NeedleInAJayStack for reporting the problem!
Several preexisting APIs had incorrectly changed from accepting
any Encodableto acceptingsome Encodable, which is source-breaking under some conditions. This restores the original use ofany(though it keeps the addedSendablerequirement).Also restores 100% test coverage after the previous fixes.
Note
Many APIs which had previously accepted a generic parameter (i.e.
<E: Encodable>), most notably inSQLPredicateBuilder, also switched to usingsome Encodable, but this was not source-breaking; the problem applied only to APIs which originally acceptedany Encodable.Although the changes in this PR are technically themselves source-breaking, since they revert a previous such breakage to its previous state, only a
semver-patchbump is necessary.