Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLEncodedForm date encoding strategy #2273

Merged
merged 32 commits into from Apr 21, 2020
Merged

URLEncodedForm date encoding strategy #2273

merged 32 commits into from Apr 21, 2020

Commits on Mar 29, 2020

  1. Added ability to configure date coding/decoding for UrlEncodedForm

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    4c6301f View commit details
    Browse the repository at this point in the history

  2. Added documentation to the DateFormat enum

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    a318cac View commit details
    Browse the repository at this point in the history

  3. renamed internetDateTime to iso8601

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    569205e View commit details
    Browse the repository at this point in the history

  4. Added custom date formatter

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    47d275c View commit details
    Browse the repository at this point in the history

  5. Added comment about ISO8601DateFormatter performance

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    ad50caa View commit details
    Browse the repository at this point in the history

  6. Added ISO8601DateFormatter.threadSpecific so a new ISO8601DateFormatt… 

    …er isn't created for every encode/decode.
    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    4f8165f View commit details
    Browse the repository at this point in the history

  7. Use typealias instead of declaring DateFormat 2x

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    f212661 View commit details
    Browse the repository at this point in the history

  8. Added ThreadSpecificDateFormatter to ensure thread safety when usin… 

    …g a `custom` DateFormat for `URLEncodedFormEncoder` or `URLEncodedFormDecoder`
    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    78908d1 View commit details
    Browse the repository at this point in the history

  9. Fixed comment

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    b9bdedb View commit details
    Browse the repository at this point in the history

  10. Changed custom interface to mimic `JSONDecoder.DateDecodingStrategy.c… 

    …ustom(_:)` and `JSONEncoder.DateEncodingStrategy.custom(_:)` interfaces
    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    287dff9 View commit details
    Browse the repository at this point in the history

  11. Removed unused ThreadSpecificDateFormatter

    @thecheatah
    thecheatah committed Mar 29, 2020
    Copy the full SHA
    bbaf3e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. ISO8601DateFormatter seems to be thread safe. This bug was filed: h… 

    …ttps://bugs.swift.org/browse/SR-7745?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel

I tried running the sample program with `10000000` iterations in the `vapor/swift:5.2` docker image without any issue.
    @thecheatah
    thecheatah committed Mar 30, 2020
    Copy the full SHA
    73617bf View commit details
    Browse the repository at this point in the history

  2. Default the date format for URLEncodedFrom coding/decoding to `timeIn… 

    …tervalSinceReferenceDate`
    @thecheatah
    thecheatah committed Mar 30, 2020
    Copy the full SHA
    2cdccb4 View commit details
    Browse the repository at this point in the history

  3. Default to timeIntervalSince1970

    @thecheatah
    thecheatah committed Mar 30, 2020
    Copy the full SHA
    ab98e1e View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Removed timeIntervalSinceReferenceDate option

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    8b96414 View commit details
    Browse the repository at this point in the history

  2. Made Date: URLQueryFragmentConvertible

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    860d81a View commit details
    Browse the repository at this point in the history

  3. Date decoding uses an array of DateFormats and tries in order

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    70d35a6 View commit details
    Browse the repository at this point in the history

  4. Comments

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    be68616 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary import

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    76ef4fe View commit details
    Browse the repository at this point in the history

  6. Comments

    @thecheatah
    thecheatah committed Mar 31, 2020
    Copy the full SHA
    4750b51 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Merged with Vapor 4.0.1

    @thecheatah
    thecheatah committed Apr 11, 2020
    Copy the full SHA
    8c99199 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Reintroduced threadSpecific ISO8601DateFormatter

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    d5cade4 View commit details
    Browse the repository at this point in the history

  2. Renamed unixTimestamp to secondsSince1970 to match Apple's naming con… 

    …vention
    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    0138d63 View commit details
    Browse the repository at this point in the history

  3. Throw last error when decodingDate using multiple decoding approaches

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    d0fcd9a View commit details
    Browse the repository at this point in the history

  4. Use DateDecodingStrategy and DateEncodingStrategy naming convention

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    b62257b View commit details
    Browse the repository at this point in the history

  5. Updated test cases

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    567f686 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into Feature/2272-URL-Coding-Internet-Dates

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    57144c5 View commit details
    Browse the repository at this point in the history

  7. Updated documentation

    @thecheatah
    thecheatah committed Apr 17, 2020
    Copy the full SHA
    2a80df9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. Added additional default test and updated documentation

    @thecheatah
    thecheatah committed Apr 19, 2020
    Copy the full SHA
    fe655cb View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Improved error handling

    @thecheatah
    thecheatah committed Apr 20, 2020
    Copy the full SHA
    914b8b7 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary comment

    @thecheatah
    thecheatah committed Apr 20, 2020
    Copy the full SHA
    0c173b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Replaced dateDecodingStrategies with dateDecodingStrategy

    @thecheatah
    thecheatah committed Apr 21, 2020
    Copy the full SHA
    bca712a View commit details
    Browse the repository at this point in the history