Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default max body size for streaming request body collection #2312

Merged
merged 16 commits into from May 1, 2020
Merged

Default max body size for streaming request body collection #2312

merged 16 commits into from May 1, 2020

Commits on Apr 14, 2020

  1. Added .defaultMaxBodySize to RouteBuilder protocol

    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    18910f0 View commit details
    Browse the repository at this point in the history

  2. Added .group(maxSize:) and .grouped(maxSize:configure:) methods to Ro… 

    …uteBuilder protocol
    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    a86288f View commit details
    Browse the repository at this point in the history

  3. Verify body size in Request.Body.collect(max:) method on .collected case

    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    f297a9b View commit details
    Browse the repository at this point in the history

  4. Changed default .collect maxSize to 1 megabyte

    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    baa184c View commit details
    Browse the repository at this point in the history

  5. Use group/router default request body sizes in RoutesBuilder.on respo… 

    …nder

There was also an issue when the request body existed before we get to the responder, the size of the body was not checked. We check it now
    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    eb89bf7 View commit details
    Browse the repository at this point in the history

  6. Created RouteTests.testConfigurableMaxBodySize test case

    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    aa6bdec View commit details
    Browse the repository at this point in the history

  7. Added check for app.routes.defaultMaxBodySize setter in RouteTests.te… 

    …stConfigurableMaxBodySize test case
    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    8b32960 View commit details
    Browse the repository at this point in the history

  8. Fix maxSize and body.readableBytes comperison operators

    @calebkleveter
    calebkleveter committed Apr 14, 2020
    Copy the full SHA
    713bb1b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. Address comments

    @jdmcd
    jdmcd committed Apr 25, 2020
    Copy the full SHA
    d130d05 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. update

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    e949d4d View commit details
    Browse the repository at this point in the history

  2. updates

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    21d1dc3 View commit details
    Browse the repository at this point in the history

  3. updates

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    b55cf05 View commit details
    Browse the repository at this point in the history

  4. updates

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    0024074 View commit details
    Browse the repository at this point in the history

  5. updates

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    deb0284 View commit details
    Browse the repository at this point in the history

  6. updates

    @tanner0101
    tanner0101 committed Apr 28, 2020
    Copy the full SHA
    b09b40a View commit details
    Browse the repository at this point in the history

  7. Fuzzy

    @jdmcd
    jdmcd committed Apr 28, 2020
    Copy the full SHA
    86e817d View commit details
    Browse the repository at this point in the history