Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support periods in cookie names #2372

Merged
merged 1 commit into from May 28, 2020
Merged

Support periods in cookie names #2372

merged 1 commit into from May 28, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented May 28, 2020 •
edited

Adds support for . in HTTP header value directive keys, like cookie names (#2372, fixes #2359).

@tanner0101 tanner0101 added bug Something isn't working semver-patch Internal changes only labels May 28, 2020
@tanner0101 tanner0101 changed the title support periods in directive keys Support periods in cookie names May 28, 2020
@tanner0101 tanner0101 marked this pull request as ready for review May 28, 2020 16:28
@tanner0101 tanner0101 merged commit 6dfdb34 into master May 28, 2020
@tanner0101 tanner0101 added this to Done in Vapor 4 via automation May 28, 2020
@tanner0101 tanner0101 deleted the tn-directive-key-period branch May 28, 2020 16:28
@tanner0101
Copy link
Member Author

These changes are now available in 4.7.1

pull bot pushed a commit to scope-demo/vapor that referenced this pull request May 28, 2020
@tanner0101 @pull
support periods in directive keys (vapor#2372)
d34a525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No request cookies if cookie name contains a dot
1 participant
@tanner0101