Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header directive parameter quoting #2441

Merged
merged 2 commits into from Jul 15, 2020
Merged

Header directive parameter quoting #2441

merged 2 commits into from Jul 15, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Jul 15, 2020 •
edited

Adds support for quoting HTTP header value directive parameters containing unsupported characters (#2411, fixes #2439).

For example:

- content-disposition: form-data; filename=foo bar
+ content-disposition: form-data; filename="foo bar"

@tanner0101 tanner0101 added bug Something isn't working semver-patch Internal changes only labels Jul 15, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Jul 15, 2020
@tanner0101 tanner0101 merged commit 75c7236 into master Jul 15, 2020
Vapor 4 automation moved this from Awaiting Review to Done Jul 15, 2020
@tanner0101 tanner0101 deleted the tn-directive-quote branch July 15, 2020 18:40
@tanner0101
Copy link
Member Author

These changes are now available in 4.20.1

1 similar comment
@tanner0101
Copy link
Member Author

These changes are now available in 4.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multipart parameter values are never quoted
1 participant
@tanner0101