Fixing issue #2755: updating config storage inside HTTPServer

[rkreutz]

We can update application.storage from within HTTPServer, this way we can keep any changes that happen to the configuration internally up-to-date with the application storage.

This possibly has the least changes and less surface of potential flaws, since we are only adding an extra param and working on top of it. However, now we are setting the application storage from within HTTPServer, there is no issue with that, is just that now we have 2 places changing the storage for the config.

Resolves #2755

[rkreutz]

this is an alternative to #2881

[0xTim]

This should have been solved in #2764 - does that match with what you were seeing?

[rkreutz]

In that PR you have reflected changes in configuration back to HTTPServer, which is just part of the fix, we also need to update application.storage[Application.HTTP.Server.ConfigKey] with the new configuration otherwise accessing application.http.server.configuration will be outdated

[0xTim]

@rkreutz ah I see - do you want to update the PR so the test reflects the missing config? Thanks!

[rkreutz]

Should we go with this approach then rather than #2881 ?

[0xTim]

Yeah this feels like a better change, keeping it as a struct if possible is desirable as we adopt Sendable throughout the codebase

[rkreutz]

@0xTim added the unit tests there d0c6778, I've reverted the changes and ran the tests and confirmed they were failing, and after reapplying the change the tests pass

[rkreutz]

Hey @0xTim anything else here you'd like to have added?

[0xTim]

Apologies, got lost in the queue! This is good to go when CI passes

[VaporBot]

These changes are now available in 4.65.2