Implement Server-Sent Events #2960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crashes when users try to write a body from within a task towards the ELF APIs
… crashes when users try to write a body from within a task towards the ELF APIs
… into feature/jo-async-body-stream # Conflicts: # Tests/VaporTests/PipelineTests.swift
Steven4294
reviewed
Feb 16, 2023
…the offset to 0, using `readableBytesView.startIndex`
Joannis
force-pushed
the
feature/jo-sse
branch
from
995b7d3
to
af64d5f
Compare
|
Do we know when this will be merged? Trying to use SSE for MacPaw OpenAI's chat stream. |
|
@wendellli99 it can't get reviewed yet, as this PR depends on the unmerged async streams PR. The PR is marked as merged, but was reverted |
|
Ok. Any chance we can get that PR merged? We are eagerly waiting for SSE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has an
sse.htmlto test theGET /sseroute in the Development app. I'll force-push that to be removed once I get a unit test as a replacement.Relies on #2939
TODO:
retry