Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snake-key decoding strategy for URLQuery #3094

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Nov 2, 2023

Adds snake-key decoding strategy for URLQuery.
Matches Foundation's JSONDecoder implementation although i found like 3 different key-handling bugs in that implementation while writing this.

@MahdiBM MahdiBM enabled auto-merge (squash) November 2, 2023 10:36
@MahdiBM MahdiBM disabled auto-merge November 2, 2023 10:36
@MahdiBM MahdiBM enabled auto-merge (squash) November 2, 2023 10:36
@MahdiBM MahdiBM disabled auto-merge November 2, 2023 10:36
@MahdiBM
Copy link
Contributor Author

MahdiBM commented Nov 2, 2023

I thought my misclick is merging the PR to main without a review 😵‍💫

@0xTim
Copy link
Member

0xTim commented Nov 2, 2023

It can't until it's had an approval

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #3094 (5673062) into main (3bf4e73) will increase coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
+ Coverage   76.23%   76.32%   +0.08%     
==========================================
  Files         211      211              
  Lines        7904     7963      +59     
==========================================
+ Hits         6026     6078      +52     
- Misses       1878     1885       +7     
Files Coverage Δ
...ces/Vapor/Authentication/AuthenticationCache.swift 84.84% <100.00%> (+0.97%) ⬆️
Sources/Vapor/Authentication/Authenticator.swift 57.89% <ø> (ø)
Sources/Vapor/Authentication/GuardMiddleware.swift 100.00% <ø> (ø)
...rces/Vapor/Authentication/RedirectMiddleware.swift 83.33% <ø> (ø)
Sources/Vapor/Error/AbortError.swift 74.41% <ø> (ø)
...s/Vapor/URLEncodedForm/URLEncodedFormDecoder.swift 88.65% <100.00%> (+2.87%) ⬆️
Sources/Vapor/Utilities/BasicCodingKey.swift 33.33% <ø> (ø)

... and 2 files with indirect coverage changes

@MahdiBM
Copy link
Contributor Author

MahdiBM commented Nov 3, 2023

hmm that didn't turn out like i was thinking it would 🤔 just caused a bunch of whitespace changes for the most part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants