Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SendableRoute type #3100

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add SendableRoute type #3100

wants to merge 27 commits into from

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Nov 6, 2023

Adds a new SendableRoute to replace Route. This is designed to be a value type from the ground up which removes the need to access properties via locks in a large number of places.

Most users should be switched over automatically.

@0xTim 0xTim added the semver-minor Contains new API label Nov 6, 2023
@0xTim 0xTim requested a review from gwynne as a code owner November 6, 2023 14:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Merging #3100 (7f39b27) into main (d682e05) will decrease coverage by 1.61%.
Report is 2 commits behind head on main.
The diff coverage is 52.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3100      +/-   ##
==========================================
- Coverage   76.27%   74.66%   -1.61%     
==========================================
  Files         211      212       +1     
  Lines        8011     8178     +167     
==========================================
- Hits         6110     6106       -4     
- Misses       1901     2072     +171     
Files Coverage Δ
Sources/Vapor/Responder/DefaultResponder.swift 99.15% <100.00%> (ø)
...urces/Vapor/Routing/RoutesBuilder+Middleware.swift 60.00% <100.00%> (-8.75%) ⬇️
Sources/Vapor/Commands/RoutesCommand.swift 1.53% <0.00%> (ø)
...rces/Vapor/Concurrency/WebSocket+Concurrency.swift 82.25% <71.42%> (-10.47%) ⬇️
Sources/Vapor/Routing/RoutesBuilder.swift 0.00% <0.00%> (ø)
...ources/Vapor/Routing/RoutesBuilder+WebSocket.swift 47.36% <82.35%> (-38.35%) ⬇️
Sources/Vapor/Routing/RoutesBuilder+Group.swift 38.88% <0.00%> (-11.12%) ⬇️
Sources/Vapor/Request/Request.swift 75.51% <0.00%> (-4.35%) ⬇️
Sources/Vapor/Routing/Routes.swift 54.28% <25.00%> (-24.89%) ⬇️
Sources/Vapor/Routing/Route.swift 0.00% <0.00%> (-52.50%) ⬇️
... and 3 more

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants