Make Middleware Async #3108
Draft
Make Middleware Async #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ import NIOCore | |||
| import NIOHTTP1 | |||
|
|
|||
| /// Captures all errors and transforms them into an internal server error HTTP response. | |||
| public final class ErrorMiddleware: Middleware { | |||
| public final class ErrorMiddleware: AsyncMiddleware { | |||
| /// Structure of `ErrorMiddleware` default response. | |||
| internal struct ErrorResponse: Codable { | |||
There was a problem hiding this comment.
While you are at it, is it possible to make ErrorResponse public?
In my project I use https://github.com/mattpolzin/VaporOpenAPI to generate the openApi.yml file from the server code and with this in turn the client facing structs - the server is the single source of truth for the models.
Right now I need to duplicate this struct and make it conform to Sampleable & OpenAPIExampleProvider for this to work, which is not ideal.
I also tried writing my own ErrorMiddleware with a public ErrorResponse struct but this failed as I couldn't use response.responseBox as its marked internal and can only be used from the vapor module.
What would be the recommended approach here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all of Vapor's internal middleware async so we can have a full async chain all the way down in anticipation of distributed tracing (and adopting NIO's new AsyncChannel stuff)