Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete socket file if it exists. Fixes #3085. #3146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

talmeme
Copy link

@talmeme talmeme commented Jan 30, 2024

#3085: If Unix domain socket file exists then Vapor crashes when starting instead of taking over the socket file.

This PR fixes by deleting the socket file if it exists.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (823f20c) to head (5755b2c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   76.82%   76.77%   -0.05%     
==========================================
  Files         211      211              
  Lines        8096     8096              
==========================================
- Hits         6220     6216       -4     
- Misses       1876     1880       +4     
Files Coverage Δ
Sources/Vapor/HTTP/Server/HTTPServer.swift 80.49% <100.00%> (ø)

... and 1 file with indirect coverage changes

@0xTim 0xTim added the semver-patch Internal changes only label Mar 20, 2024
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay in this - do you think it would be possible to write a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants