Remove HeadResponder #3147
Merged
Remove HeadResponder #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
approved these changes
Jan 30, 2024
0xTim
requested changes
Mar 20, 2024
baarde
force-pushed
the
remove-head-responder
branch
from
8f88aad
to
23ecce2
Compare
|
@0xTim I think this is already covered by |
The HEAD method is identical to GET except that the server must not send content in the response (RFC 9110, section 9.3.2). The previous default behaviour of returning 200 OK to every HEAD request to a constant route is not standard-compliant. The new behaviour is to always forward the request to the GET route, unless the developer explicitly configured a custom HEAD route.
baarde
force-pushed
the
remove-head-responder
branch
from
23ecce2
to
42658b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
==========================================
- Coverage 76.86% 76.54% -0.33%
==========================================
Files 211 211
Lines 8119 7677 -442
==========================================
- Hits 6241 5876 -365
+ Misses 1878 1801 -77
|
Closed
0xTim
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Ah I missed that. Ok this looks fine to me
@owainhunt since you did the original PR, does the overriding as described work for you?
|
LGTM 👍 |
keniwhat
pushed a commit
to keniwhat/vapor
that referenced
this pull request
Apr 27, 2024
* main: Patch configuration and log actual port on startup (vapor#3160) Update provider tests to 5.10 (vapor#3178) Migrate to Async NIOFileIO APIs (vapor#3167) Removed streamFile deprecation + deactivated advancedETagComparison by default (vapor#3177) Remove HeadResponder (vapor#3147) Advanced ETag Comparison now supported (vapor#3015) Enabled Request Decompression By Default (vapor#3175) HTTP2 Response Compression/Request Decompression (vapor#3126) Don't set ignore status for SIGTERM and SIGINT on Linux (vapor#3174) Fix typos across the codebase (vapor#3162) Fix some Sendable warnings on 5.10 (vapor#3158) Allow `HTTPServer`'s configuration to be dynamically updatable (vapor#3132) Fix issue when client disconnects midway through a stream (vapor#3102) Fix handling of "flag" URL query params (vapor#3151) Bump the dependencies group with 1 update (vapor#3148) Merge Async Tests (vapor#3141) Fix URI handling with multiple slashes and variable components. (vapor#3143) Fix broken URI behaviors (vapor#3140) # Conflicts: # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.93.1
The HEAD method is identical to GET except that the server must not send content in the response (RFC 9110, section 9.3.2).
The previous default behaviour of returning 200 OK to every HEAD request to a constant route is not standard-compliant.
The new behaviour is to always forward the request to the GET route, unless the developer explicitely configured a custom HEAD route.
This PR fixes #2680 and #2749.