Use "best for platform" EventLoopGroup instead of always using MultiThreadedEventLoopGroup
#3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiThreaded` `EventLoopGroup`
MahdiBM
commented
Apr 12, 2024
| .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.19.0"), | ||
| .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.21.0"), |
There was a problem hiding this comment.
It is kind of unrelated to the goal of this PR but it should be fine considering the version comes with the HTTPClient.shared and is going to be needed by something if not Vapor.
|
I think we've deliberately avoided doing this in the past for various reasons; NIOTS is really only valuable on iOS. |
|
Yeah we need to do a bit of rearchitecting if we want to support NIOTS properly and frankly that's going to wait until Vapor 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.