Make # of connections accepted per event loop cycle configurable, and raise the default #3186
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
approved these changes
May 4, 2024
|
I'd wait for @0xTim too, since he works more with these lower-level stuff. |
What, you think I'd merge this on your say-so alone? 😂😉 |
gwynne
force-pushed
the
configurable-accept-quantum
branch
from
7611eeb
to
caf7bc5
Compare
|
@gwynne 🫠 😂 of course you would, I know you count every second before you can hit the merge buttons. |
weissi
reviewed
May 4, 2024
gwynne
force-pushed
the
configurable-accept-quantum
branch
from
caf7bc5
to
67311b7
Compare
… event loop tick configurable.
gwynne
force-pushed
the
configurable-accept-quantum
branch
from
67311b7
to
22afd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.96.0
As per @weissi's suggestion in this forums post, we raise the default maximum number of connections accepted per cycle of the server's event loop from 4 to 256, and the value is now user-configurable.
There are no new tests for this because I'm not sure if there's a way to measure the effect of changing this value that doesn't involve nondeterministic timing measurements.
Also takes the opportunity/excuse to add the missing
customCertificateVerifyCallbackparameter to the initializers ofHTTPServer.Configuration.