Support compiling against Musl #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vapor already makes some provision for compiling against Musl in the RFC1123 implementation, where `Glibc` is not assumed and is imported conditionally alongside a conditional import of `Musl`. However, there are a couple of other places where `Glibc` is still assumed when compiling for Linux. This patch replaces these imports with the same `#if canImport(...)` pattern.
|
Waiting on vapor/console-kit#198 to discuss if we can test this in CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
==========================================
+ Coverage 76.86% 77.23% +0.36%
==========================================
Files 211 210 -1
Lines 8119 8044 -75
==========================================
- Hits 6241 6213 -28
+ Misses 1878 1831 -47
|
gwynne
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.99.2
Vapor already makes some provision for compiling against Musl in the RFC1123 implementation, where
Glibcis not assumed and is imported conditionally alongside a conditional import ofMusl. However, there are a couple of other places whereGlibcis still assumed when compiling for Linux.This patch replaces these imports with the same
#if canImport(...)pattern.