-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async alternative for Application.shutdown #3189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the template with these new APIs.
Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
Yep that's how I discovered this when updating the template |
self.logger.trace("Application shutdown complete") | ||
} | ||
|
||
public func asyncShutdown() async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this throwing? I don’t see anything throwing in the function, and it makes me “eat” the error when running the shutdown in a catch block.
These changes are now available in 4.99.0
Adds an async alternative for
Application.shutdown()
and annotatesshutdown()
withnoasync