Async Serve Command #3190
Merged
Async Serve Command #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to work out why the configuration has broken in the tests |
|
Verified this works with vapor/template#131 with Leaf and Fluent and all working |
gwynne
reviewed
May 11, 2024
| headers: request.headers | ||
| ) | ||
| clientRequest.body = .byteBuffer(request.body) | ||
| let response = try await client.execute(request: clientRequest).get() |
There was a problem hiding this comment.
Why is .get() needed here? HTTPClient has an async version of execute() (with different argument labels).
|
@gwynne this is ready for you now I think |
gwynne
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.99.3
Migrate
ServeCommandto anAsyncCommandto enable proper custom executor support and remove any calls towait()