Update URLEncodedFormEncoder encoding rules #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
requested changes
May 13, 2024
ptoffy
commented
May 13, 2024
Comment on lines
+77
to
+78
| var allowed = CharacterSet.alphanumerics | ||
| allowed.insert(charactersIn: "*-._") |
There was a problem hiding this comment.
I'm honestly not sure why this is allowing [ and ]
There was a problem hiding this comment.
Originally because of Vapor's support for "array" URL parameters, but that doesn't matter for this usage.
ptoffy
changed the title
$ in URLEncodedFormEncoder
0xTim
approved these changes
May 20, 2024
gwynne
reviewed
May 20, 2024
Comment on lines
-165
to
+169
| Date(timeIntervalSince1970: 10_000), | ||
| Date(timeIntervalSince1970: 20_000), | ||
| Date(timeIntervalSince1970: 30_000), | ||
| Date(timeIntervalSince1970: 40_000), | ||
| Date(timeIntervalSince1970: 50_000), | ||
| Date(timeIntervalSince1970: 10000), | ||
| Date(timeIntervalSince1970: 20000), | ||
| Date(timeIntervalSince1970: 30000), | ||
| Date(timeIntervalSince1970: 40000), | ||
| Date(timeIntervalSince1970: 50000), |
There was a problem hiding this comment.
Honestly, turn down the settings on your code formatter, this is a change for the worse 🤣
gwynne
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.100.1
Solves #3173
References https://url.spec.whatwg.org/#application-x-www-form-urlencoded-percent-encode-set to set the encoding rules