Copy timeouts from a via backend if undefined for the destination #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
force-pushed
the
via_inherit_timeouts
branch
from
a52a79d
to
aebbc56
Compare
nigoroll
force-pushed
the
via_inherit_timeouts
branch
from
aebbc56
to
468942e
Compare
nigoroll
commented
May 27, 2024
| #define CPTMO(a, b, x) do { \ | ||
| if ((a)->x < 0.0 || isnan((a)->x)) \ | ||
| (a)->x = (b)->x; \ | ||
| } while(0) |
There was a problem hiding this comment.
bugwash: should have a blank line here
note: use of isnan() is for forward compatibility, at the moment, we use -1 to denone NAN for backends.
nigoroll
force-pushed
the
via_inherit_timeouts
branch
from
468942e
to
6d1ea03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherit the three backend timeouts from a proxy if not defined for the destination.
TODO before merge if otherwise accepted: changes.rst, documentation