Add build workflow job with concentrated docs artefact #1310
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: Infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 229 229
Lines 3754 3754
Branches 1011 1011
=======================================
Hits 3543 3543
Misses 81 81
Partials 130 130 ☔ View full report in Codecov by Sentry. |
wadamek65
reviewed
Mar 11, 2024
scripts/concatenateDocs.sh
Outdated
| #!/bin/bash | ||
|
|
||
| # Check if the correct number of arguments are passed | ||
| if [ "$#" -ne 2 ]; then |
There was a problem hiding this comment.
Could we write this in .js or something to make this OS-agnostic?
There was a problem hiding this comment.
The main purpose is to use it in the CI, so I don't know if it is really needed, but it won't hurt for sure, so I made it.
Monteth
requested review from
wadamek65,
zaxoavoki,
zendranm,
piotrpospiech and
ErnestTeluk
kestarumper
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow by decoupling the documentation build and deployment steps from the integrity checks. We have introduced a new job that only runs after the CI checks have successfully completed. In the previous setup, there was a possibility that the documentation could be deployed when using Node.js version 20.x, even if tests failed in other versions within the matrix. This issue has now been addressed and prevented. Additionally, we have included an artifact that compiles all documentation into a single file. This compiled document is intended for use with the uniforms assistant custom GPT model.