New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material ui v4 #543
Material ui v4 #543
Conversation
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 162 162
Lines 1491 1491
=====================================
Hits 1491 1491 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it usable with @material-ui/core@4
, you need to change this line only. Top level package.json
and package-lock.json
are being used only in the tests and documentation (playground). Updating the above line and tests will be enough - we can switch to the newer version internally later.
Alright, I updated the package requirements, any reason to undo the top-level |
Yeah, actually two: one, this change has almost completely rewritten the |
Okay, just so I get this right, I undo all the changes (including tests, since the ones I fixed depend on root |
Updating package dependencies is enough. If you’d like to add these tests too, then leave the top level dependencies updated but update the lock file as little as possible. I can do it later today. |
Done. I had to update |
Here's the migration checklist: https://material-ui.com/guides/migration-v3/
It doesn't seem to me that this package uses almost any of the changed features. I fixed a couple tests, only the target had to change.
Also, instead of pinning material-ui I let it loose, they have followed semver very well with proper deprecations before any braking changes in their major versions. Since they regularly add new features in their minor versions, that will give users of this package a bit more flexibility.
Closes #542.