Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material ui v4 #543

Merged
merged 1 commit into from Jun 18, 2019
Merged

Material ui v4 #543

merged 1 commit into from Jun 18, 2019

Conversation

Floriferous
Copy link
Contributor

Here's the migration checklist: https://material-ui.com/guides/migration-v3/

It doesn't seem to me that this package uses almost any of the changed features. I fixed a couple tests, only the target had to change.

Also, instead of pinning material-ui I let it loose, they have followed semver very well with proper deprecations before any braking changes in their major versions. Since they regularly add new features in their minor versions, that will give users of this package a bit more flexibility.

Closes #542.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #543   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         162    162           
  Lines        1491   1491           
=====================================
  Hits         1491   1491

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1a1a2...c9b3739. Read the comment docs.

@radekmie radekmie assigned radekmie and unassigned radekmie Jun 13, 2019
@radekmie radekmie added the Type: Feature New features and feature requests label Jun 13, 2019
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it usable with @material-ui/core@4, you need to change this line only. Top level package.json and package-lock.json are being used only in the tests and documentation (playground). Updating the above line and tests will be enough - we can switch to the newer version internally later.

@Floriferous
Copy link
Contributor Author

Alright, I updated the package requirements, any reason to undo the top-level package.json version changes?

@radekmie
Copy link
Contributor

Yeah, actually two: one, this change has almost completely rewritten the package-lock.json file (even not related to this update), two, as a rule, each change should be minimal. Also, this change added two not needed (and problematic in a monorepo) files, namely website/package-lock.json and packages/uniforms-material/package-lock.json.

@Floriferous
Copy link
Contributor Author

Floriferous commented Jun 16, 2019

Okay, just so I get this right, I undo all the changes (including tests, since the ones I fixed depend on root material-ui@4), except the package.json in uniforms-material/package.json ?

@radekmie
Copy link
Contributor

Updating package dependencies is enough. If you’d like to add these tests too, then leave the top level dependencies updated but update the lock file as little as possible. I can do it later today.

@radekmie
Copy link
Contributor

Done. I had to update enzyme and adapter too, because of enzymejs/enzyme#2146.

@radekmie radekmie merged commit 154cab9 into vazco:master Jun 18, 2019
@Monteth Monteth added this to Closed in Open Source (migrated) Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Material-UI v4
2 participants