[1.6] Use shared_ptr for library entities #4025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes manual memory management from VCMI_Lib classes (handlers) and replaces raw pointers with shared_ptr.
Effectively independent part of #3997.
Originally intended to use unique_ptr instead, but that turned out to be more complex & resulted in less readable code. Kind of wish there was smart pointer which defines only one 'owner' and possible 'borrowers' (other than raw pointers or weak_ptr which can be easily promoted to shared_ptr).
List of changes: