Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop runtime dependency on base64 #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Earlopain
Copy link

@Earlopain Earlopain commented Feb 5, 2024

#1003 added base64 as a runtime dependency. It's easy enough to replace, the base64 is for the most part a wrapper around the pack/unpack methods.

Also see:

I have made it a dev dependency since one test file uses it in a bunch of places and replacing all that doesn't make the code much better.

@dentarg
Copy link
Contributor

dentarg commented Feb 28, 2024

Why? The abstraction is there for a reason!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants