Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding number of users for each language in get languages endpoint #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nunogoncalves
Copy link
Contributor

Hi @vdaubry

I decided to make it an option because up until now the return was an array of strings instead of objects.

Since I have the app in production it would break things (V1 should have the return type always as a Language object (name: "", users:""... whatever). This way it wouldn't break things when adding fields like this example.

So in this case if we send the boolean, we get an array of objects, if not we still get an array of strings..
Not perfect, but what I came up with.

Let me know what you think.

@nunogoncalves nunogoncalves changed the title Master Adding number of users for each language in get languages endpoint Jan 29, 2016
@nunogoncalves nunogoncalves reopened this Jan 29, 2016
@jayvdb
Copy link

jayvdb commented Sep 6, 2016

Inconsistent use of single vs double quotes, but otherwise looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants