Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could we optimize interactions by setting signals instead of re-writing the spec? #540

Open
jonathanzong opened this issue Apr 22, 2021 · 0 comments
Assignees
Labels
enhancement lyra2019 Issues pertaining to the lyra2019 working branch

Comments

@jonathanzong
Copy link
Member

jonathanzong commented Apr 22, 2021

currently, in the interactions code, when you change an Interaction definition it will re-render the whole visualization and write out different signals into the spec. this was easier to implement, but means that changing the interaction definition is somewhat costly, and there's often a couple seconds of delay afterward. i wonder if it would be more efficient to write out all the signal specs one might possibly need and then set signal values that switch interactions on/off using the pattern set up for mark encodings in signalActions and ctrl/signals.ts. ideally, this would mean changing the interaction definition would no longer require a re-render.

@jonathanzong jonathanzong added enhancement lyra2019 Issues pertaining to the lyra2019 working branch labels Apr 22, 2021
@jonathanzong jonathanzong self-assigned this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement lyra2019 Issues pertaining to the lyra2019 working branch
Projects
None yet
Development

No branches or pull requests

1 participant