feat: adding support for intersection of arrays and tuples #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
reviewed
May 2, 2022
| return this.childTypeFormatter.getDefinition(types[0]); | ||
| } | ||
|
|
||
| const requirements: Definition[] = []; |
There was a problem hiding this comment.
Dependencies may be a better word.
domoritz
approved these changes
May 3, 2022
|
|
||
| types.forEach((t) => { | ||
| if (t instanceof ArrayType || t instanceof TupleType) { | ||
| /** |
| const dependencies: Definition[] = []; | ||
| const nonArrayLikeTypes: BaseType[] = []; | ||
|
|
||
| types.forEach((t) => { |
| }); | ||
|
|
||
| if (nonArrayLikeTypes.length) { | ||
| /** |
| if (t instanceof ArrayType || t instanceof TupleType) { | ||
| /** | ||
| * Arrays are not easily mergeable | ||
| * So it's just easier to append their defs |
There was a problem hiding this comment.
I would add these comments higher up and focus more on the why than the what.
There was a problem hiding this comment.
I'm not sure I quite understand what you mean by the "why vs what". I will be moving the comments higher up in the in chain for now though.
There was a problem hiding this comment.
Comments should explain why we are doing something and now what is happening in the code.
filipomar
force-pushed
the
array-and-tuple-intersection
branch
from
f6112e9
to
2c2e655
Compare
This was referenced May 25, 2022
This was referenced Sep 21, 2022
Merged
|
馃殌 PR was released in |
github-actions
bot
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for intersection of arrays and tupples such as:
Types originally from here.
Version
Published prerelease version:
v1.1.0-next.3Changelog
馃帀 This release contains work from new contributors! 馃帀
Thanks for all your work!
鉂わ笍 null@filipomar
鉂わ笍 Remi Cattiau (@loopingz)
鉂わ笍 Hadrien Milano (@hmil)
馃殌 Enhancement
馃悰 Bug Fix
@description#1177 (@Jason3S)馃敥 Dependency Updates
Authors: 8