ci: don't add message to released prs #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like it doesn't work reliably for prereleases. I would have expected the annotation to be updated.
|
I'm not seeing the github release annotation- did you disable this feature after deciding it wasn't up to date enough? Handy to know that this exists as an option for repos where auto is not set up. |
|
Nope, I haven't disabled it and still see it in #1417. Closing since the comments seem to be more useful than what GitHub produces. |
|
Odd, maybe it’s a per account setting or an experimental feature - I don’t
see the GitHub green callout in the linked PR, or a release note for this
feature from GitHub yet. Nice to know the feature is likely on its way
though.
…On Thu, Sep 22, 2022 at 10:35 PM Dominik Moritz ***@***.***> wrote:
Nope, I haven't disabled it and still see it in #1417
<#1417>.
Closing since the comments seem to be more useful than what GitHub
produces.
—
Reply to this email directly, view it on GitHub
<#1415 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2MMZUZ7J2JQUWJ5D4QSDV7UJOJANCNFSM6AAAAAAQRUVNAU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think GitHub already adds the annotations so we don't need it, do we?