Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support bun #1737

Merged
merged 3 commits into from Aug 2, 2023
Merged

fix: support bun #1737

merged 3 commits into from Aug 2, 2023

Conversation

CodeFromAnywhere
Copy link
Contributor

@CodeFromAnywhere CodeFromAnywhere commented Jul 30, 2023 •
edited by github-actions bot

This small extra check fixes a crash in bun.js, which is super helpful for my use case. Obviously doesn't fix the root cause, but at least I can keep using this.

Version

Published prerelease version: v1.3.0-next.8

Changelog

馃帀 This release contains work from new contributors! 馃帀

Thanks for all your work!

鉂わ笍 Code From Anywhere (@CodeFromAnywhere)

鉂わ笍 Chris (@cengels)

鉂わ笍 Grigas (@grigasp)

鉂わ笍 Mario DeSousa (@mdesousa)

鉂わ笍 Grant Dickinson (@grant-d)

馃殌 Enhancement

馃悰 Bug Fix

鈿狅笍 Pushed to next

馃敥 Dependency Updates

Authors: 11

@domoritz
Copy link
Member

domoritz commented Aug 1, 2023

Tests are failing.

@CodeFromAnywhere CodeFromAnywhere mentioned this pull request Aug 2, 2023
Closed
domoritz
domoritz approved these changes Aug 2, 2023
View reviewed changes
src/NodeParser/TypeReferenceNodeParser.ts Outdated Show resolved Hide resolved
@domoritz domoritz changed the title fixes bun crash fix: support bun Aug 2, 2023
@domoritz domoritz merged commit 8c740b8 into vega:next Aug 2, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Merged
@github-actions
Copy link

馃殌 PR was released in v1.3.0 馃殌

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
prerelease released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CodeFromAnywhere @domoritz