fix: preserve node order in swapwithparents

vega · Dec 8, 2021 · 9460999 · 9460999
1 parent 6299dd8
commit 9460999
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/compile/data/dataflow.ts b/src/compile/data/dataflow.ts
@@ -116,11 +116,14 @@ export abstract class DataFlowNode {
     // remove old links
     this._children = []; // equivalent to removing every child link one by one
     parent.removeChild(this);
-    parent.parent.removeChild(parent);
+    const loc = parent.parent.removeChild(parent);
 
     // swap two nodes
-    this.parent = newParent;
-    parent.parent = this;
+    this._parent = newParent;
+    newParent.addChild(this, loc);
+
+    parent._parent = this
+    this.addChild(parent, loc);
   }
 }