fix: use expression to generalize zeroOrMinOrMax when there is a scale

vega · May 9, 2024 · bbeeff9 · bbeeff9
1 parent cd7d913
commit bbeeff9
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/src/compile/mark/encode/zeroOrMinOrMax.ts b/src/compile/mark/encode/zeroOrMinOrMax.ts
@@ -20,6 +20,21 @@ export function zeroOrMinOrMax({
     };
   }
 
+  if (scaleName) {
+    const domain = `domain('${scaleName}')`;
+    const min = `${domain}[0]`;
+    const max = `${domain}[1]`;
+
+    switch (mode) {
+      case 'min':
+        return {signal: `scale('${scaleName}', ${min})`}; // encode the scale domain min
+      case 'zeroOrMin':
+        return {signal: `scale('${scaleName}', inrange(0, ${domain}) ? 0 : ${min})`}; // encode the scale domain min
+      default: //zeroOrMax
+        return {signal: `scale('${scaleName}', inrange(0, ${domain}) ? 0 : ${max})`}; // encode the scale domain min
+    }
+  }
+
   if (mode === 'zeroOrMin' || mode === 'min') {
     switch (mainChannel) {
       case 'radius':