Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure compatibility with TS 3.7 #5497

Merged
merged 1 commit into from Oct 29, 2019
Merged

fix: ensure compatibility with TS 3.7 #5497

merged 1 commit into from Oct 29, 2019

Conversation

domoritz
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #5497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5497   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         161      161           
  Lines        8439     8439           
  Branches     2269     2269           
=======================================
  Hits         8126     8126           
  Misses        241      241           
  Partials       72       72
Impacted Files Coverage Δ
src/spec/facet.ts 100% <ø> (ø) ⬆️
src/spec/repeat.ts 100% <ø> (ø) ⬆️
src/transform.ts 100% <ø> (ø) ⬆️
src/bin.ts 100% <ø> (ø) ⬆️
src/projection.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdceb36...692ac42. Read the comment docs.

@jasongrout
Copy link

Thanks!

@domoritz
Copy link
Member Author

I'm going to merge this since the problems in the imports are just refactorings.

@domoritz domoritz merged commit 64c98d7 into master Oct 29, 2019
@domoritz domoritz deleted the dom/ts-37 branch October 29, 2019 19:10
@jasongrout
Copy link

Do you have a timeline for release? (not to hurry or pressure you, just wanting to know when I can check back and resume work on jupyterlab/jupyterlab#7428).

@domoritz
Copy link
Member Author

I'm hoping to get Vega-Lite 4 out in November so we don't block you. We can make a beta release anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants