fix: set binSuffix for defined channel #7931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrosenzweig
changed the title
|
@domoritz I fixed the Typescript issue. |
|
@domoritz I wanted to make sure you saw my update here. I think this is good to go, but let me know! |
|
Thank you for the ping. This looks great. Thank you! |
|
pull request with updated examples in #7973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the change I want, but I'm not familiar with the code base. Should the
binSuffixlogic be consolidated? I saw it appears in at least one other place (mark.ts).Resolves #7930