ci: don't skip the ci when we have automatic commits #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind
approved these changes
Apr 4, 2022
hydrosquall
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Thinking through the logic of why CI skip was present in the past
[ci skip]is put in place to avoid a situation where you have an infinite loop (github actions repeatedly spawning more github actions)- These specific situations are OK to not CI skip because they're guarded by branches that should not be re-entered after the contents of those branches have been run (specifically
git status --porcelainandgit diff
With these two reasoning steps in mind, I'm reasonably confident that "skipping the skips" won't lead to an infinite chain of commits being made, so it's safe to change our commit messaging scheme.
|
Same. I think we could add a safeguard where ci commits don't spawn new commits but I think these should be safe so let's merge. |
|
🚀 PR was released in |
Merged
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we skip CI for commits coming from the CI: #8088.
📦 Published PR as canary version:
5.2.1--canary.8089.0345f00.0✨ Test out this PR locally via:
npm install vega-lite@5.2.1--canary.8089.0345f00.0 # or yarn add vega-lite@5.2.1--canary.8089.0345f00.0