Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples: interactive earthquakes map - remove faulty rotation #8379

Closed

Conversation

pared
Copy link
Contributor

@pared pared commented Aug 23, 2022

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

I tried fixing the issues pointed by @mattijn in #8138, so far no results. So I guess it's better to leave a single rotation axis, to have a somewhat correct example. I will summarize my findings under the original PR where the discussion takes place.

@pared pared force-pushed the prd/examples_interactive_earthquakes_update branch from 4c35605 to e526fbf Compare August 23, 2022 15:54
@pared
Copy link
Contributor Author

pared commented Aug 29, 2022

Closing, will retry fixing and using projection as in discussion in #8138

@pared pared closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant